aaron.ballman added inline comments.
Comment at: clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:34
+
+ diag(N->getLocation(),
+ "modification of '%0' namespace can result in undefined behavior")
I think this will still trigger false positives because
xazax.hun updated this revision to Diff 88333.
xazax.hun marked 9 inline comments as done.
xazax.hun added a comment.
- Updated to latest trunk.
- The cert rule was renamed, the patch is updated accordingly.
- Fixes as per review comments.
https://reviews.llvm.org/D23421
Files:
falho added a comment.
Unfortunately I wont have time to work on this check anymore... thank you for
understanding!
Repository:
rL LLVM
https://reviews.llvm.org/D23421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Unfortunatelly I wont have time now to work on this check... Thank you for
understanding!
On Mon, Feb 6, 2017 at 3:44 PM, Gábor Horváth via Phabricator <
revi...@reviews.llvm.org> wrote:
> xazax.hun added a comment.
>
> Benedek, do you have time to address the review comments or do you want me
>
xazax.hun added a comment.
Benedek, do you have time to address the review comments or do you want me to
commandeer this revision?
Repository:
rL LLVM
https://reviews.llvm.org/D23421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun added inline comments.
Comment at: test/clang-tidy/cert-dont-modify-std-namespace.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s cert-msc53-cpp %t -- -- -std=c++1z
+
hokein wrote:
> Do we need `c++1z` flag here?
I think it is there for the following
hokein added inline comments.
Comment at: clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:20
@@ +19,3 @@
+
+void DontModifyStdNamespaceCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(namespaceDecl(unless(isExpansionInSystemHeader()),
This
aaron.ballman added a comment.
Thank you for working on this check! There is a slight problem, however, in
that the check as-written will flag false positives because there are times
when it is permissible to modify the std namespace. The important bit of the
CERT requirement is "Do not add
