Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth closed this revision. amccarth added a comment. Closed by r278861 https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689 @@ -1687,3 +1687,4 @@ - if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()) + if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() && + !CXXDecl->hasAttr()) return true;

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68225. amccarth added a comment. Add comment as requested. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689 @@ -1687,3 +1687,4 @@ - if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()) + if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() && + !CXXDecl->hasAttr()) return true;

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68114. amccarth added a comment. Added a test. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added a comment. Thank, dblaikie, for correcting my terminology. https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits