This revision was automatically updated to reflect the committed changes.
Closed by commit rL354265: [ARM] Add pre-defined macros for ROPI and RWPI
(authored by olista01, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D23610?vs=91990=187220#toc
Repository:
rL LLVM
olista01 added a comment.
Yes, the back-end work was all done years ago, I just also forgot about these
while waiting for the ACLE to be published.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D23610/new/
https://reviews.llvm.org/D23610
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, this fell out of my radar and just saw the ping now.
Given it's in ACLE and there are only mechanical (obvious) changes, LGTM.
I'm assuming those two parameters are
olista01 added a comment.
These macros have been in the published ACLE for a while now:
https://developer.arm.com/products/software-development-tools/compilers/arm-compiler-5/docs/101028/latest/5-feature-test-macros#position-independent-code
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
kahmed added a comment.
Herald added subscribers: llvm-commits, jdoerfert, kristof.beyls, javed.absar.
Herald added a project: LLVM.
Ping
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D23610/new/
https://reviews.llvm.org/D23610
olista01 added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D23610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
olista01 updated this revision to Diff 91990.
olista01 retitled this revision from "[ARM] Add pre-defined macros for ROPI,
RWPI and FPIC" to "[ARM] Add pre-defined macros for ROPI and RWPI".
olista01 edited the summary of this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D23610
