Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279559: driver: Support checking for rlimits via cmake (when bootstrapping) (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23744?vs=68775=69028#toc Repository: rL LLVM

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-23 Thread Chris Bieneman via cfe-commits
Landed in r279559! Thanks, -Chris > On Aug 23, 2016, at 10:44 AM, Michał Górny wrote: > > mgorny added a comment. > > Thanks for the review. Could you commit it for me, please? I don't have > commit access. > > > https://reviews.llvm.org/D23744 > > >

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-23 Thread Michał Górny via cfe-commits
mgorny added a comment. Thanks for the review. Could you commit it for me, please? I don't have commit access. https://reviews.llvm.org/D23744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-23 Thread Chris Bieneman via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Patch LGTM. https://reviews.llvm.org/D23744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-23 Thread Vedant Kumar via cfe-commits
vsk resigned from this revision. vsk edited reviewers, added: beanz; removed: vsk. vsk added a comment. I don't see any issues with this patch, but I'm generally unfamiliar with the bootstrapping process and think Chris could give a better review. (Also, as Richard pointed out earlier,

[PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-20 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: rsmith, vsk. mgorny added a subscriber: cfe-commits. Add a cmake check for sys/resource.h and replace the __has_include() check with its result, in order to make it possible to use rlimits when building with compilers not supporting