[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-10-19 Thread Michał Górny via cfe-commits
mgorny added a comment. Do you think I should just focus on the suffix, or maybe try to make the whole path configurable? https://reviews.llvm.org/D23752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-10-17 Thread Chris Bieneman via cfe-commits
beanz added a comment. Looking more closely at this, there is a problem that I see. The clang runtime directory only supports building compiler-rt, and is going to be replaced by the llvm runtimes directory in the (hopefully near) future. Maybe a better way to go is to define

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-10-17 Thread Michał Górny via cfe-commits
mgorny added a comment. A gentle ping. https://reviews.llvm.org/D23752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-09-23 Thread Chris Bieneman via cfe-commits
beanz added a reviewer: rnk. beanz added a comment. This looks reasonable to me, but I'm not super familiar with multi-lib conventions. I think @chandlerc is more familiar with how that stuff works. https://reviews.llvm.org/D23752 ___ cfe-commits

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-08-21 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: chandlerc, chapuni, samsonov. mgorny added a subscriber: cfe-commits. Make it possible to override the value of CLANG_LIBDIR_SUFFIX, and use it uniformly to control install location of runtimes (i.e. lib/clang), therefore supporting sharing