[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

appcs added a comment. In D23934#3314277 , @appcs wrote: > Hello, Will this feature be committed? Thanks! In D23934#3355355 , @emaste wrote: > The original author appears to have given up on it. Someone will

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

appcs added a comment. In D23934#3355355 , @emaste wrote: > The original author appears to have given up on it. Someone will need to > rebase and work on pushing it forward Please see: https://reviews.llvm.org/D121040 CHANGES SINCE LAST ACTION

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Herald added a project: All. The original author appears to have given up on it. Someone will need to rebase and work on pushing it forward CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

appcs added a comment. Herald added a subscriber: dang. Hello, Will this feature be committed? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

Alexander added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2252 + TM.tm_isdst = -1; + mktime(); + Opts.FixedDateTime = TM; efriedma wrote: > Does using mktime like this depend on the local timezone? Since the return value of

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

Alexander added a comment. What is the status of this issue? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

efriedma added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2252 + TM.tm_isdst = -1; + mktime(); + Opts.FixedDateTime = TM; Does using mktime like this depend on the local timezone? https://reviews.llvm.org/D23934

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

vsapsai added a comment. Cannot tell for sure from code but looks like we are still emitting `-Wdate-time` "expansion of date or time macro is not reproducible" with this flag. At least it's not covered by tests. And another similar warning is `-Wpch-date-time`.

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Ping? https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

hfinkel added a comment. In https://reviews.llvm.org/D23934#632216, @emaste wrote: > Please also accept `SOURCE_DATE_EPOCH` set in the environment -- see > https://reproducible-builds.org/specs/source-date-epoch/ It looks like there's reasonable adoption of this:

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Please also accept `SOURCE_DATE_EPOCH` set in the environment -- see https://reproducible-builds.org/specs/source-date-epoch/ Also although I'm generally leery of options auto-detecting the argument format, I think we should be able to pass an epoch timestamp to

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

hfinkel added a comment. In https://reviews.llvm.org/D23934#631656, @ed wrote: > I'd be interested in seeing a feature like this appearing. I agree. Comment at: lib/Driver/Tools.cpp:4687 +CmdArgs.push_back(Args.MakeArgString("-ffixed-date-time=" + DateTime)); + } +

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

ed added a comment. I'd be interested in seeing a feature like this appearing. Any chance this feature may be part of Clang 4.0? https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

thakis created this revision. thakis added a reviewer: rsmith. thakis added a subscriber: cfe-commits. This is useful for creating reproducible builds. Defining these via -D triggers warnings, and can cause bugs (presently, e.g. PR29119). It makes it also impossible to override __DATE__ and