This revision was automatically updated to reflect the committed changes.
Closed by commit rL280062: clang-rename: improve error message when -old-name
is used and could not find… (authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D24002?vs=69644=69646#toc
Repository:
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D24002#528556, @vmiklos wrote:
> > Probably something like "could not find symbol OldName" would be
> > reasonable, too.
>
>
> OK, changed.
Great! Good catch,
vmiklos marked an inline comment as done.
vmiklos added a comment.
> Probably something like "could not find symbol OldName" would be reasonable,
> too.
OK, changed.
https://reviews.llvm.org/D24002
___
cfe-commits mailing list
vmiklos updated this revision to Diff 69644.
https://reviews.llvm.org/D24002
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/InvalidOldName.cpp
Index: test/clang-rename/InvalidOldName.cpp
===
--- /dev/null
+++
omtcyfz added inline comments.
Comment at: clang-rename/USRFindingAction.cpp:168
@@ +167,3 @@
+ } else
+errs() << "clang-rename: could not find symbol named " << OldName
+ << ".\n";
I am not sure whether "could not find symbol
vmiklos created this revision.
vmiklos added reviewers: klimek, omtcyfz.
vmiklos added a subscriber: cfe-commits.
Old output was:
clang-rename: could not find symbol at
tools/clang/tools/extra/test/clang-rename/ClassFindByName.cpp:1:1 (offset 0).
https://reviews.llvm.org/D24002
Files:
