logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as rL283118 with the suggested change
regarding to `is_sh_test` assertion.
https://reviews.llvm.org/D24087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added inline comments.
Comment at: test/libcxx/test/format.py:69
@@ +68,3 @@
+name_root, name_ext = os.path.splitext(name)
+is_sh_test = name_root.endswith('.sh')
+is_pass_test = name_root.endswith('.pass')
logan wrote:
> EricWF
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Woops I see the test case now. LGTM.
Comment at: test/libcxx/test/format.py:69
@@ +68,3 @@
+name_root, name_ext = os.path.splitext(name)
+is_sh_test =
EricWF added a comment.
I don't think assembly based `.pass` and `.fail` tests will work quite yet. The
`CXXCompiler` object used by the test format explicitly passes `-xc++ %s` in
some cases.
I'm assuming you already have a libc++abi assembly test? Could you put it up
for review?
logan created this revision.
logan added reviewers: mclow.lists, EricWF.
logan added a subscriber: cfe-commits.
This commit splits the file extensions before determining the test
format. This allows libc++abi to add assembly-based test cases.
https://reviews.llvm.org/D24087
Files:
