This revision was automatically updated to reflect the committed changes.
Closed by commit rL282371: [AMDGPU] Expose flat work group size, register and
wave control attributes (authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D24513?vs=71970=72436#toc
Repository:
rL
tstellarAMD accepted this revision.
tstellarAMD added a comment.
LGTM.
https://reviews.llvm.org/D24513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl added a comment.
Thanks for the review Aaron!
Tom, would you be able to do a final glance over?
https://reviews.llvm.org/D24513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D24513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kzhuravl added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4967
@@ +4966,3 @@
+
+ D->addAttr(::new (S.Context)
+ AMDGPUFlatWorkGroupSizeAttr(Attr.getLoc(), S.Context, Min, Max,
aaron.ballman wrote:
> Is it okay to supply `0, 0` as the min,
kzhuravl updated this revision to Diff 71970.
kzhuravl added a comment.
Herald added a subscriber: kzhuravl.
Mention `0, 0` case in the docs.
https://reviews.llvm.org/D24513
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4967
@@ +4966,3 @@
+
+ D->addAttr(::new (S.Context)
+ AMDGPUFlatWorkGroupSizeAttr(Attr.getLoc(), S.Context, Min, Max,
Is it okay to supply `0, 0` as the min, max arguments?
kzhuravl added inline comments.
Comment at: include/clang/Basic/Attr.td:1067
@@ +1066,3 @@
+ let Spellings = [GNU<"amdgpu_waves_per_eu">];
+ let Args = [UnsignedArgument<"Min">, VariadicUnsignedArgument<"Max">];
+ let Documentation = [AMDGPUWavesPerEUDocs];
kzhuravl updated this revision to Diff 71449.
kzhuravl marked 15 inline comments as done.
kzhuravl added a comment.
Address review feedback
https://reviews.llvm.org/D24513
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
aaron.ballman requested changes to this revision.
This revision now requires changes to proceed.
Comment at: include/clang/Basic/Attr.td:1054-1056
@@ -1058,3 +1053,5 @@
+//
// FIXME: This should be for OpenCLKernelFunction, but is not to
// workaround needing to see kernel
kzhuravl updated this revision to Diff 71382.
kzhuravl added a comment.
Fix minor typos
https://reviews.llvm.org/D24513
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
kzhuravl updated the summary for this revision.
kzhuravl updated this revision to Diff 71311.
kzhuravl added a comment.
Update docs in AttrDocs.td
https://reviews.llvm.org/D24513
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
kzhuravl created this revision.
kzhuravl added reviewers: arsenm, aaron.ballman.
kzhuravl added subscribers: yaxunl, kanarayan, cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: nhaehnle, wdng.
__attribute__((amdgpu_flat_work_group_size(, ))) - request minimum
and
13 matches
Mail list logo
