Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-29 Thread Jonas Hahnfeld via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282701: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D24601?vs=72765&id=72960#toc Repository: rL LLVM h

Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-28 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D24601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-27 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld updated the summary for this revision. Hahnfeld updated this revision to Diff 72765. Hahnfeld added a comment. Link PR https://reviews.llvm.org/D24601 Files: test/Driver/darwin-stdlib.cpp test/lit.cfg test/lit.site.cfg.in Index: test/lit.site.cfg.in =

Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-27 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. In https://reviews.llvm.org/D24601#553482, @vsk wrote: > It should be fine to XFAIL this test temporarily. Is there a PR for this? I've now created an entry in Bugzilla: https://llvm.org/bugs/show_bug.cgi?id=30548 https://reviews.llvm.org/D24601 _

Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-26 Thread Vedant Kumar via cfe-commits
vsk added a subscriber: vsk. vsk added a comment. It should be fine to XFAIL this test temporarily. Is there a PR for this? https://reviews.llvm.org/D24601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-23 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. ping https://reviews.llvm.org/D24601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

2016-09-15 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld created this revision. Hahnfeld added a reviewer: t.p.northover. Hahnfeld added a subscriber: cfe-commits. Until someone rewrites the stdlib logic for Darwin so that we don't need to pass down the -stdlib argument to cc1. https://reviews.llvm.org/D24601 Files: test/Driver/darwin-stdli