dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.
Submitted in 282582.
https://reviews.llvm.org/D24628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dvyukov added a comment.
LGTM
Any other comments? Or I will submit it tomorrow.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:7
@@ +6,3 @@
+// RUN: %clangxx_asan -std=c++11 -lpthread -O3 %s -o %t && %run %t 2>&1 |
FileCheck %s
+// RUN: %clangxx_asan
andriigrynenko updated this revision to Diff 72571.
andriigrynenko added a comment.
Do CHECKs for all iterations of the loop.
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
andriigrynenko added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199
@@ -164,7 +175,26 @@
ret += Run(argc - 1, 0, stack);
+// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]]
+// CHECK: Main context from: [[CHILD_STACK]] 524288
dvyukov added a comment.
We need a test that passes non-NULL to these arguments and shows how to use the
returned values.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199
@@ -164,7 +175,26 @@
ret += Run(argc - 1, 0, stack);
+// CHECK: Child
andriigrynenko added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199
@@ -164,7 +175,26 @@
ret += Run(argc - 1, 0, stack);
+// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]]
+// CHECK: Main context from: [[CHILD_STACK]] 524288
andriigrynenko updated this revision to Diff 71717.
andriigrynenko added a comment.
Addressing comments.
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
test/asan/TestCases/Linux/swapcontext_annotation.cc
filcab added a comment.
Please add some printf calls to the test, to show that you have the correct
stack+size, too.
Thanks for working on this.
Filipe
Comment at: lib/asan/asan_thread.cc:141
@@ -140,3 +140,3 @@
if (!fake_stack_save && current_fake_stack)
andriigrynenko updated this revision to Diff 71698.
andriigrynenko added a comment.
update unit test to use non-null values
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
blastrock added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9
@@ -8,3 +8,3 @@
// This test is too subtle to try on non-x86 arch for now.
-// REQUIRES: x86_64-supported-target,i386-supported-target
+// REQUIRES: x86-target-arch
dvyukov added a comment.
We need a test that passes non-NULL to these arguments and shows how to use the
returned values.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:47
@@ -46,3 +46,3 @@
CallNoReturn();
- __sanitizer_finish_switch_fiber();
+
andriigrynenko added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9
@@ -8,3 +8,3 @@
// This test is too subtle to try on non-x86 arch for now.
-// REQUIRES: x86_64-supported-target,i386-supported-target
+// REQUIRES: x86-target-arch
andriigrynenko updated this revision to Diff 71677.
andriigrynenko added a comment.
fix the unit test
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
test/asan/TestCases/Linux/swapcontext_annotation.cc
blastrock added a comment.
Seems fine to me, but I think you forgot to update the tests :)
Repository:
rL LLVM
https://reviews.llvm.org/D24628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
andriigrynenko created this revision.
andriigrynenko added reviewers: kcc, blastrock, dvyukov, filcab.
andriigrynenko added a subscriber: cfe-commits.
andriigrynenko set the repository for this revision to rL LLVM.
Herald added a subscriber: kubabrecka.
This patch extends
15 matches
Mail list logo
