This revision was automatically updated to reflect the committed changes.
Closed by commit rL282625: [clang-tidy] fix false-positive for
cppcoreguidelines-pro-type-member-init… (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D24848?vs=72677=72885#toc
Repository:
rL
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24848#555636, @mgehre wrote:
> Are you okay with me committing this as it currently is?
Yes.
https://reviews.llvm.org/D24848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgehre added a comment.
I would like to close that particular bug report, and thus I would like to have
the reproducer of that bug as part of the test case.
The PositivePartiallyInClassInitialized is also a good test, but I fail to see
how it is proves that that particular bug is solved.
Are
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24848#554145, @mgehre wrote:
> Rename the struct that was introduced in the test. Note that I need to keep
> the function Bug30487,
> because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24965
On Tue, Sep 27, 2016 at 2:05 PM, Matthias Gehre wrote:
> mgehre updated this revision to Diff 72677.
> mgehre added a comment.
>
> Rename the struct that was introduced in the test. Note that I need to keep
> the function Bug30487,
> because that is where the false-positive
mgehre updated this revision to Diff 72677.
mgehre added a comment.
Rename the struct that was introduced in the test. Note that I need to keep the
function Bug30487,
because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24848
Files:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with Malcom's test suggestions addressed.
https://reviews.llvm.org/D24848
___
cfe-commits mailing list
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:372
@@ +371,3 @@
+
+struct Bug30487
+{
There's already this test:
```
struct NegativeInClassInitialized {
int F = 0;
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
This fixes https://llvm.org/bugs/show_bug.cgi?id=30487 where
```
warning: uninitialized record type: 's'