This revision was automatically updated to reflect the committed changes.
Closed by commit rL283526: [clang-move] Support moving multiple classes in one
run. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25309?vs=73888&id=73890#toc
Repository:
rL LLVM
https://revi
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:316
auto InMovedClass =
- hasDeclContext(cxxRecordDecl(hasName(FullyQualifiedName)));
+ hasDeclContext(cxxRecordDecl(*InMovedClassNames));
ioeric wrote:
> hokein wrote:
> > ioeric w
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg. Thanks!
https://reviews.llvm.org/D25309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
hokein updated this revision to Diff 73888.
hokein marked 3 inline comments as done.
hokein added a comment.
Update.
https://reviews.llvm.org/D25309
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
t
ioeric added inline comments.
> hokein wrote in ClangMove.cpp:316
> "InMovedClassNames" should not be false in the matcher. Added an assert.
I think you should instead exit early if `ClassNames.empty()` or assert not
empty.
> ClangMove.cpp:299
> + for (StringRef ClassName : ClassNames) {
> +
hokein added inline comments.
> ioeric wrote in ClangMove.cpp:316
> What would happen if `InMovedClassNames == false`?
"InMovedClassNames" should not be false in the matcher. Added an assert.
https://reviews.llvm.org/D25309
___
cfe-commits mailing
hokein updated this revision to Diff 73819.
hokein marked 7 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25309
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_
ioeric added inline comments.
> ClangMove.cpp:295
> void ClangMoveTool::registerMatchers(ast_matchers::MatchFinder *Finder) {
> - std::string FullyQualifiedName = "::" + Spec.Name;
> + auto ParseNames = [](llvm::StringRef Names) {
> +SmallVector ClassNames;
Why create this lambda if it's
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25309
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/I
