mgorny closed this revision.
mgorny added a comment.
r283746
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Thanks for the review.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ggreif accepted this revision.
ggreif added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny updated this revision to Diff 74111.
mgorny added a comment.
Updated to use TC.getCompilerRT().
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/montavista-gcc-toolchain.c
phosek added a comment.
I have submitted the same change https://reviews.llvm.org/D25256 a few days ago
but this one seems to be getting more traction so I'm going to abandon mine in
favor of this one.
Comment at: lib/Driver/Driver.cpp:1000
+case
mgorny updated this revision to Diff 74063.
mgorny added a comment.
I'm sorry, I mixed branches up. Here's the correct patch with both updates.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
mgorny added a reviewer: ggreif.
mgorny updated this revision to Diff 74062.
mgorny added a comment.
Including a fix for montavista toolchain checks that miss passing -rtlib= and
therefore could fail depending on DEFAULT_* value.
https://reviews.llvm.org/D25338
Files:
mgorny requested a review of this revision.
mgorny added a comment.
I have updated the patch to include a feature check for platforms rejecting
`-rtlib=libgcc` and split the test appropriately. Could you re-review, please?
https://reviews.llvm.org/D25338
mgorny removed rL LLVM as the repository for this revision.
mgorny updated this revision to Diff 73979.
This revision is now accepted and ready to land.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
mgorny planned changes to this revision.
mgorny added a comment.
Reverted, I need to update it to run libgcc part of the test only on platforms
supporting that.
Repository:
rL LLVM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
mgorny added a comment.
It seems that my test doesn't work on Darwin, and I should exclude the libgcc
part there. Do you happen to have any suggestion how to do that?
I'm going to wait for other buildbots to finish to see if I haven't broken any
other platform, then revert it and look for a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283572: [Driver] Make -print-libgcc-file-name print
compiler-rt lib when used (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25338?vs=73887=73953#toc
Repository:
rL LLVM
mgorny added a comment.
Thanks for the review.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny updated this revision to Diff 73887.
mgorny added a comment.
A simple test case included.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/print-libgcc-file-name.c
Index:
mgorny marked 2 inline comments as done.
mgorny added a comment.
Updated the docs. I'll look into the test case tomorrow.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny updated this revision to Diff 73855.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
bruno added a reviewer: bruno.
bruno added a comment.
Testcase?
> clang.rst:398
> + Print the library path for the currently used compiler runtime library
> + ("libgcc.a" or "libclang_rt.builtins.*.a" appropriately).
>
You can probably drop the "appropriately"
> Options.td:1865
> +
mgorny created this revision.
mgorny added a reviewer: ddunbar.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: dberris.
Make the -print-libgcc-file-name option print an appropriate compiler
runtime library, that is libgcc.a if gcc runtime is used
and an appropriate compiler-rt
20 matches
Mail list logo
