[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284112: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D25429?vs=74109=74497#toc Repository: rL LLVM

[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-10 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. I am in support of this as well. https://reviews.llvm.org/D25429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-10 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. The change seems to be reasonable, and the size increase is not huge. However, I'm not sure who should make the call. https://reviews.llvm.org/D25429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-10 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D25429#565940, @NoQ wrote: > In https://reviews.llvm.org/D25429#565939, @xazax.hun wrote: > > > I might be confused, but as far as I remember, when you do static linking, > > symbols tend to be linked in lazily. So as long as you do not use

[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-10 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D25429#565939, @xazax.hun wrote: > I might be confused, but as far as I remember, when you do static linking, > symbols tend to be linked in lazily. So as long as you do not use the > matchers, those numbers might be misleading. Yep, i did

[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-10 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. I might be confused, but as far as I remember, when you do static linking, symbols tend to be linked in lazily. So as long as you do not use the matchers, those numbers might be misleading. https://reviews.llvm.org/D25429

[PATCH] D25429: [analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

2016-10-10 Thread Artem Dergachev via cfe-commits
NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin, alexfh. NoQ added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. ASTMatchers are sometimes handy in the Analyzer, and there are more patches to make use of them. However, it turns