danielcdh added a comment.
ping...
Thanks,
Dehao
https://reviews.llvm.org/D25435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielcdh updated this revision to Diff 81609.
danielcdh added a comment.
update option name
https://reviews.llvm.org/D25435
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/Driver/Tools.cpp
danielcdh added a comment.
In https://reviews.llvm.org/D25435#619169, @hfinkel wrote:
> In https://reviews.llvm.org/D25435#609320, @danielcdh wrote:
>
> > change the flag name to -fprofile-debug
>
>
> I don't really like this name because it sounds like it might be enabling
> some kind of
hfinkel added a comment.
In https://reviews.llvm.org/D25435#609320, @danielcdh wrote:
> change the flag name to -fprofile-debug
I don't really like this name because it sounds like it might be enabling some
kind of debugging of the profiling. How about -fdebug-info-for-profiling.
Another
danielcdh added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745
if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs &&
!CGM.getCodeGenOpts().EmitGcovNotes &&
+
echristo added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745
if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs &&
!CGM.getCodeGenOpts().EmitGcovNotes &&
+
danielcdh added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745
if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs &&
!CGM.getCodeGenOpts().EmitGcovNotes &&
+
echristo added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745
if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs &&
!CGM.getCodeGenOpts().EmitGcovNotes &&
+
danielcdh added a comment.
ping
https://reviews.llvm.org/D25435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielcdh updated this revision to Diff 79770.
danielcdh added a comment.
change the flag name to -fprofile-debug
https://reviews.llvm.org/D25435
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDebugInfo.cpp
gbedwell added a comment.
In https://reviews.llvm.org/D25435#608348, @danielcdh wrote:
> Change the flag to -fprof-debug, which is more concise. The flag name is
> still open for discussion.
Well, since I have permission to bikeshed... :)
I'd prefer to have 'profile' rather than 'prof' in
danielcdh updated this revision to Diff 79629.
danielcdh marked an inline comment as done.
danielcdh added a comment.
Change the flag to -fprof-debug, which is more concise. The flag name is still
open for discussion.
https://reviews.llvm.org/D25435
Files:
include/clang/Driver/Options.td
12 matches
Mail list logo
