This revision was automatically updated to reflect the committed changes.
Closed by commit rL284007: [CodeCompletion] Show protocol properties that are
accessed through qualified id (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25436?vs=74227=74364#toc
Repository:
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:3723
}
} else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) {
// Objective-C property reference.
manmanren wrote:
> I feel like the added logic belongs to here :]
arphaman updated this revision to Diff 74227.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch handles protocol properties together with the interface
properties.
Repository:
rL LLVM
https://reviews.llvm.org/D25436
Files:
manmanren added a comment.
Thanks for working on this!
Manman
Comment at: lib/Sema/SemaCodeComplete.cpp:3723
}
} else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) {
// Objective-C property reference.
I feel like the added logic
arphaman created this revision.
arphaman added reviewers: manmanren, doug.gregor.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves code completion for properties that are declared in
Objective-C protocols by making sure that
