[PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284292: [Coverage] Support for C++17 switch initializers (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25539?vs=74552=74752#toc Repository: rL LLVM

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-14 Thread Igor Kudrin via cfe-commits
ikudrin accepted this revision. ikudrin added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-13 Thread Vedant Kumar via cfe-commits
vsk updated the summary for this revision. vsk updated this revision to Diff 74552. vsk added a comment. Per @arphaman's comments: - Add a CodeGenPGO test which checks whether counters can be created for statements inside of switch initializers. - Group calls to 'Visit' together.

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-13 Thread Alex Lorenz via cfe-commits
arphaman added a comment. > I'm unsure about whether or not the CodeGenPGO change in this patch deserves > more testing. It wouldn't harm to add a test for CodeGenPGO as well. A good test that you can as a starting point for the new one is `test/Profile/cxx-rangefor.cpp`. A single `PGOGEN`

Re: [PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-13 Thread Alex L via cfe-commits
On 13 October 2016 at 03:42, Richard Smith wrote: > Do we need the same change for if-statements too? > Yes, a similar change should be made for them as well. > > On 12 Oct 2016 6:26 pm, "Vedant Kumar via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > >> vsk

Re: [PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-12 Thread Richard Smith via cfe-commits
Do we need the same change for if-statements too? On 12 Oct 2016 6:26 pm, "Vedant Kumar via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > vsk created this revision. > vsk added reviewers: arphaman, ikudrin. > vsk added a subscriber: cfe-commits. > > Generate coverage mappings for in

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

2016-10-12 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added reviewers: arphaman, ikudrin. vsk added a subscriber: cfe-commits. Generate coverage mappings for in switch (; ). I'm unsure about whether or not the CodeGenPGO change in this patch deserves more testing. https://reviews.llvm.org/D25539 Files: