This revision was automatically updated to reflect the committed changes.
Closed by commit rL285127: Use linker flag --fix-cortex-a53-843419 on Android
ARM64 compilation. (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D25761?vs=75174=75801#toc
Repository:
rL LLVM
srhines updated this revision to Diff 75174.
srhines added a comment.
Added a test for this behavior.
I missed that "-### -v" was actually working correctly last night. Tests added
so I am more satisfied that this won't break accidentally in the future.
https://reviews.llvm.org/D25761
Files:
rengolin added a comment.
In https://reviews.llvm.org/D25761#573903, @srhines wrote:
> > I think "clang -v" will show the linker invocation, with all its flags.
>
> But is there a way to get a dry-run of the linker? I don't want to run
> /usr/bin/ld for ARM targets. It seems like all of the
srhines added a comment.
In https://reviews.llvm.org/D25761#573902, @rengolin wrote:
> In https://reviews.llvm.org/D25761#573892, @srhines wrote:
>
> > From what I can tell, there is no nice way to generate tests for Clang's
> > driver when producing linker flags. -### only works for the -cc1
rengolin added a comment.
In https://reviews.llvm.org/D25761#573892, @srhines wrote:
> From what I can tell, there is no nice way to generate tests for Clang's
> driver when producing linker flags. -### only works for the -cc1 command line
> (which won't see this flag, since it is only for
srhines added a comment.
From what I can tell, there is no nice way to generate tests for Clang's driver
when producing linker flags. -### only works for the -cc1 command line (which
won't see this flag, since it is only for linking, and not compilation). If
there is a suggestion for how to
jmolloy accepted this revision.
jmolloy added a reviewer: jmolloy.
jmolloy added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
srhines created this revision.
srhines added a reviewer: cfe-commits.
srhines added subscribers: danalbert, pirama.
Herald added subscribers: tberghammer, rengolin, aemerson.
This is only forced on if there is no non-Cortex-A53 CPU specified as
well. Android's platform and NDK builds need to
