This revision was automatically updated to reflect the committed changes.
Closed by commit rL284735: [clang-tidy] Simplify modernize-use-default
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25769?vs=75140=75307#toc
Repository:
rL LLVM
ioeric accepted this revision.
ioeric added inline comments.
Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85
+ // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default'
+ // CHECK-FIXES: /* don't delete */ = default;
int Field;
djasper accepted this revision.
djasper added a reviewer: djasper.
djasper added a comment.
I don't know whether it is an intentional choice to remove this comment. I'd be
fine either way (I think there are arguments for and against it). So, this
looks good to me. But maybe Eric has something
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit, but you may want to wait for @djasper to weigh in on the
removed comment question.
Comment at:
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85
+ // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default'
+ // CHECK-FIXES: /* don't delete */ = default;
int Field;
I don't know why cleanup removes
malcolm.parsons created this revision.
malcolm.parsons added reviewers: angelgarcia, aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
clang-tidy now cleans up after replacements, so leave colon and comma
removal to that.
https://reviews.llvm.org/D25769
Files:
