hans added a comment.
In https://reviews.llvm.org/D25779#574630, @majnemer wrote:
> Why did this only fail with -flto? Seems strange.
I was asking myself the same thing :-) It's because of this code in
MicrosoftCXXABI::getVirtualFunctionPointer:
if (CGM.getCodeGenOpts().PrepareForLTO) // XX
majnemer added a comment.
Why did this only fail with -flto? Seems strange.
Repository:
rL LLVM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284624: MS ABI: Fix assert when generating virtual function
call with virtual bases and… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D25779?vs=75171&id=75177#toc
Repository:
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans created this revision.
hans added a reviewer: pcc.
hans added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
getClassAtVTableLocation() was calling ASTRecordLayout::getBaseClassOffset() on
a virtual base, causing an assert.
https://reviews.llvm.org/D25779
Files:
lib/
