[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

2016-10-25 Thread Michał Górny via cfe-commits
mgorny added inline comments. Comment at: unittests/Driver/ToolChainsTest.cpp:154 + "BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";)); + ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem)); +} bruno wrote: >

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

2016-10-25 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. This is great! Comment at: unittests/Driver/ToolChainsTest.cpp:154 + "BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";)); + ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem)); +} Can

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

2016-10-25 Thread Michał Górny via cfe-commits
mgorny planned changes to this revision. mgorny added inline comments. Comment at: unittests/Driver/ToolChainsTest.cpp:15 +// FIXME: I presume this is not the correct way of doing this +#include "../lib/Driver/ToolChains.h" +#include "clang/Basic/VirtualFileSystem.h"

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

2016-10-25 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. Very nice. Comment at: unittests/Driver/ToolChainsTest.cpp:15 +// FIXME: I presume this is not the correct way of doing this +#include "../lib/Driver/ToolChains.h" +#include "clang/Basic/VirtualFileSystem.h" Yeah. It's better to hoist t

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

2016-10-21 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: bruno, bkramer, rafael. mgorny added a subscriber: cfe-commits. Herald added a subscriber: beanz. Add a set of unit tests for the DetectDistro() function in Driver. Make the function itself (and the enum) visible in the library for the tests.