[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285175: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask. (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D25902?vs=75557=75830#toc Repository:

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

delena accepted this revision. delena added a comment. This revision is now accepted and ready to land. LGTM. Agree, one-by-one. https://reviews.llvm.org/D25902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

craig.topper added inline comments. Comment at: lib/Headers/avx512fintrin.h:8394 _MM_FROUND_CUR_DIRECTION); } delena wrote: > Using vfmaddss3_mask is wrong in this case. > It will propagate -B to lower bits if mask==0. I dont' understand this. The

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

delena added inline comments. Comment at: lib/Headers/avx512fintrin.h:8394 _MM_FROUND_CUR_DIRECTION); } Using vfmaddss3_mask is wrong in this case. It will propagate -B to lower bits if mask==0. Comment at:

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

craig.topper created this revision. craig.topper added reviewers: delena, igorb. craig.topper added a subscriber: cfe-commits. The preserved input should be the first argument and the vector inputs should be in the same order as the intrinsics it is used to implement.