This revision was automatically updated to reflect the committed changes.
Closed by commit rL285644: [ASTMatcher] Add CXXNewExpr support to
hasDeclaration (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26032?vs=76316&id=76490#toc
Repository:
rL LLVM
https:
klimek accepted this revision.
klimek added a comment.
Yep, makes sense. Open issues are all about types :)
https://reviews.llvm.org/D26032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Assuming @klimek agrees with the design, this LGTM. If you don't hear from
Manuel by next Wed, I think you're okay to commit (we can always roll it back
post-commit if needed).
lukasza added a comment.
FWIW, a non-owner LGTM:
- CXXNewExpr seems very similar to CallExpr, so it makes sense that
hasDeclaration would behave similarily for both of these expressions (i.e.
matching the "callee")
- The issues we've been trying to work through in
https://reviews.llvm.org/D243
aaron.ballman added a reviewer: lukasza.
aaron.ballman added a subscriber: lukasza.
aaron.ballman added a comment.
I think this is the right way to go, but I know that @klimek and @lukasza have
been working on `hasDeclaration()` issues recently, so I am wondering what
their thoughts are as well.
