This revision was automatically updated to reflect the committed changes.
Closed by commit rL286354: [Sema] Avoid -Wshadow warnings for shadowed
variables that aren't captured (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26278?vs=77205=77328#toc
Repository:
rL
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman updated this revision to Diff 77205.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch introduces a new warning group named
`-Wshadow-uncaptured-local` that was suggested by Reid.
Repository:
rL LLVM
https://reviews.llvm.org/D26278
Files:
rnk added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:361
+def warn_decl_shadow_all :
+ Warning<"declaration shadows a %select{"
+ "local variable|"
Use the .Text accessor like we do here to avoid repeating the text:
```
def
arphaman updated this revision to Diff 77201.
arphaman added a comment.
The updated patch preserves the old behaviour in `-Wshadow-all`
Repository:
rL LLVM
https://reviews.llvm.org/D26278
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
rnk added a comment.
I'd like to preserve the old behavior under -Wshadow-all. The last time I came
here to try to quiet a shadowing warning on constructor parameters, we went to
great lengths to try to satisfy users who really want to warn on any and all
kinds of shadowing. I think you can do
arphaman created this revision.
arphaman added reviewers: rsmith, rnk.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch avoids the -Wshadow warning for variables which shadow variables
that aren't captured by lambdas with an explicit
