[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

2016-11-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287618: [analyzer] Fix a crash on accessing a field within a literal-initialized union. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26442?vs=77316=78826#toc Repository:

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

2016-11-21 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. @NoQ , @ilya-palachev - what are the plans for this ? Repository: rL LLVM https://reviews.llvm.org/D26442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

2016-11-11 Thread Artem Dergachev via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this patch is good to land, but if you have time i'd suggest to investigate this a little bit deeper in order to squash even more bugs. My concern is that we've never implemented reading

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

2016-11-10 Thread Artem Dergachev via cfe-commits
NoQ added a comment. Wow, this crash must have been hard to notice! I think we shouldn't be default-binding non-lazy compound values. Normally we unpack them into field bindings right away, but it seems that nobody cared to implement this for unions. The current crash goes through

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

2016-11-09 Thread Ilya Palachev via cfe-commits
ilya-palachev created this revision. ilya-palachev added reviewers: dcoughlin, zaks.anna, NoQ. ilya-palachev added subscribers: cfe-commits, a.sidorin. ilya-palachev set the repository for this revision to rL LLVM. If the pointer to the uninitialized union is casted to the structure of another