This revision was automatically updated to reflect the committed changes.
Closed by commit rL288158: Protect std::string tests under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26612?vs=78012=79583#toc
Repository:
rL LLVM
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D26612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rogfer01 added a comment.
Ping?
https://reviews.llvm.org/D26612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 updated this revision to Diff 78012.
rogfer01 added a comment.
Restructure to minimize code duplication.
https://reviews.llvm.org/D26612
Files:
test/std/strings/basic.string/string.capacity/capacity.pass.cpp
test/std/strings/basic.string/string.ops/string_substr/substr.pass.cpp
mclow.lists added a comment.
We've been using a different pattern for this kind of tests (as we support more
and more noexcept cases). Something like this (for the second change):
template
void
test(const S& s, typename S::size_type pos, typename
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
https://reviews.llvm.org/D26612
Files:
