joey closed this revision.
joey marked 3 inline comments as done.
joey added a comment.
Committed as r287343.
Repository:
rL LLVM
https://reviews.llvm.org/D26746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
A few minor comments regarding outdated comments and style.
Comment at: include/clang/AST/ASTContext.h:1124
/// \brief Return pipe type for the specified
Anastasia added a comment.
Earlier related discussion: https://reviews.llvm.org/D17821
Repository:
rL LLVM
https://reviews.llvm.org/D26746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joey created this revision.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
Split the PipeType into two derived classes. This allows Sema to diagnose
passing read_only to write_only and vice versa.
Repository:
rL