This revision was automatically updated to reflect the committed changes.
Closed by commit rL300189: [analyzer] Enforce super-region classes for various
memory regions. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D26838?vs=79537=95093#toc
Repository:
rL LLVM
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279
/// associated element type, index, and super region.
const ElementRegion *getElementRegion(QualType elementType, NonLoc Idx,
+
NoQ updated this revision to Diff 79537.
NoQ marked 5 inline comments as done.
NoQ added a comment.
Thanks for the comments!
Addressed.
https://reviews.llvm.org/D26838
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
include/clang/StaticAnalyzer/Core/PathSensitive/Store.h
xazax.hun added a comment.
In general I really like this change. See some of my comments inline.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279
/// associated element type, index, and super region.
const ElementRegion
a.sidorin added a comment.
Hi Artem!
I like this change mostly but I also have some remarks.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279
/// associated element type, index, and super region.
const ElementRegion *getElementRegion(QualType
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
Put a lot of compile-time and run-time checks on classes of super regions of
all `SubRegion` classes, in order to maintain the existing status quo.
This should make
