This revision was automatically updated to reflect the committed changes.
Closed by commit rL288263: [analyzer] Construct temporary objects of correct
types, destroy them properly. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D26839?vs=79540=79783#toc
Repository:
NoQ updated this revision to Diff 79540.
NoQ marked an inline comment as done.
NoQ added a comment.
Update the comment.
https://reviews.llvm.org/D26839
Files:
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/lifetime-extension.cpp
Index: test/Analysis/lifetime-extension.cpp
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This is great!
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:205
- // We need to be careful about treating a derived type's value as
- // bindings for a base
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: test/Analysis/lifetime-extension.cpp:11
+ int j[2];
+ S s;
+ A() : i(1) {
alexshap wrote:
> what is the role of S in this test ?
I copy-pasted this from the original bug report. The
NoQ updated this revision to Diff 78478.
https://reviews.llvm.org/D26839
Files:
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/lifetime-extension.cpp
Index: test/Analysis/lifetime-extension.cpp
===
--- /dev/null
+++
alexshap added inline comments.
Comment at: test/Analysis/lifetime-extension.cpp:11
+ int j[2];
+ S s;
+ A() : i(1) {
what is the role of S in this test ?
https://reviews.llvm.org/D26839
___
cfe-commits mailing
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added subscribers: nandor, cfe-commits.
1. Re-use approach used in codegen. `MaterializeTemporaryExpr` may be
positioned in a strange manner, above the member access to the temporary, which
makes it
