This revision was automatically updated to reflect the committed changes.
Closed by commit rL288083: IRGen: Remove all uses of CreateDefaultAlignedLoad.
(authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D27157?vs=79436&id=79462#toc
Repository:
rL LLVM
https://reviews.llvm
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGBuilder.h:126
// FIXME: these "default-aligned" APIs should be removed,
// but I don't feel like fixing all the builtin code right now.
llvm::StoreInst *CreateDefaultAlignedStore(llvm::Value *Val,
--
pcc added inline comments.
Comment at: clang/lib/CodeGen/CGBuilder.h:126
// FIXME: these "default-aligned" APIs should be removed,
// but I don't feel like fixing all the builtin code right now.
llvm::StoreInst *CreateDefaultAlignedStore(llvm::Value *Val,
---
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGBuilder.h:126
// FIXME: these "default-aligned" APIs should be removed,
// but I don't feel like fixing all the builtin code right now.
llvm::StoreInst *CreateDefaultAlignedStore(llvm::Value *Val,
--
pcc added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2195
LoadInst *Load =
-Builder.CreateDefaultAlignedLoad(IntToPtr, /*isVolatile=*/true);
+Builder.CreateAlignedLoad(IntTy, IntToPtr, CharUnits::fromQuantity(4));
+Load->setVolatile(true
pcc updated this revision to Diff 79436.
pcc marked an inline comment as done.
pcc added a comment.
- Address review comments
https://reviews.llvm.org/D27157
Files:
clang/lib/CodeGen/CGBuilder.h
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGObjCGNU.cpp
rjmccall added a comment.
Thanks for doing this! A couple minor questions / comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2195
LoadInst *Load =
-Builder.CreateDefaultAlignedLoad(IntToPtr, /*isVolatile=*/true);
+Builder.CreateAlignedLoad(IntTy, IntT
pcc created this revision.
pcc added a reviewer: rsmith.
pcc added subscribers: cfe-commits, rjmccall.
https://reviews.llvm.org/D27157
Files:
clang/lib/CodeGen/CGBuilder.h
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGObjCGNU.cpp
clang/lib/CodeGen/Targ