STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r288751.
https://reviews.llvm.org/D27267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Random thought: It would be nice for C++ to have a
`non_truncating_cast(value)` which generated an error when the conversion
performs a truncation. This seems like the behavior we
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int'
[or 'unsigned int'], possible loss of data", part 1/4.
Replace "int n = str_.size();" with "int