[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 80810. STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Changed test/std/re/re.traits/value.pass.cpp to iterate with wchar_t as requested. https://reviews.llvm.org/D27544 Files:

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT marked an inline comment as done. STL_MSFT added inline comments. Comment at: test/std/re/re.traits/value.pass.cpp:119 } for (int c = 'g'; c < 0x; ++c) { EricWF wrote: > Can't we just make `c` a `wchar_t` like above? Yes

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/std/re/re.traits/value.pass.cpp:119 } for (int c = 'g'; c < 0x; ++c) { Can't we just make `c` a

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.