STL_MSFT abandoned this revision.
STL_MSFT added a comment.
Verified compiler fix. Abandoning this patch - nothing has been committed.
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
STL_MSFT added a comment.
Actually, the compiler bug was resolved as fixed earlier today. Verifying...
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
STL_MSFT added a comment.
Hmm, would a pragma guarded by _MSC_VER be better? I can easily do that. I've
tried to avoid cluttering the test with VC-specific pragmas, but I understand
your concern about initializing too much memory.
https://reviews.llvm.org/D27555
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm happy to work around this one issue but in general I dislike initializing
memory to avoid compile-time warnings. Doing so prevents the sanitizers from
catching actual uninitialized memory
STL_MSFT added a comment.
It was debatable to me whether this was actually a compiler bug, but I suppose
that it can see size()'s definition and should be able to notice that the
elements aren't accessed. I've filed VSO#300037 "Bogus warning C6001 "Using
uninitialized memory" for
EricWF added a comment.
Are you planning on fixing this in your compiler?
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".
/analyze sees array::size() being called on arrays with garbage-inited doubles,
and complains. It doesn't