Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D27569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
echuraev updated this revision to Diff 81917.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D27569
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/Initialization.h
include/clang/Sema/Overload.h
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprAgg.cpp
Anastasia added inline comments.
Comment at: test/SemaOpenCL/queue_t_overload.cl:10
+ foo(0, src2);
+ foo(q, src3); // expected-error {{call to 'foo' is ambiguous}}
+}
could we also add something non-convertible for queue i.e.
foo(1, src3);
echuraev updated this revision to Diff 81742.
echuraev marked 3 inline comments as done.
https://reviews.llvm.org/D27569
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/Initialization.h
include/clang/Sema/Overload.h
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprAgg.cpp
echuraev updated this revision to Diff 81372.
echuraev marked 4 inline comments as done.
https://reviews.llvm.org/D27569
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/Initialization.h
include/clang/Sema/Overload.h
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprAgg.cpp
Anastasia added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9624
+ if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200) {
+if (LHSIsNull && RHSType->isQueueT()) {
getLangOpts().OpenCL is redundant because getLangOpts().OpenCLVersion is
echuraev created this revision.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: bader, yaxunl, cfe-commits.
Enabling the compression of CLK_NULL_QUEUE to variable of type queue_t.
https://reviews.llvm.org/D27569
Files:
lib/Sema/SemaExpr.cpp
