This revision was automatically updated to reflect the committed changes.
Closed by commit rL290888: [libcxxabi] Introduce an externally threaded
libc++abi variant. (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D27575?vs=81062=82868#toc
Repository:
rL LLVM
EricWF added a comment.
Why don't we commit this as is and we can deal with the mutex later?
https://reviews.llvm.org/D27575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added inline comments.
Comment at: src/fallback_malloc.cpp:37
class mutexor {
public:
EricWF wrote:
> rmaprath wrote:
> > EricWF wrote:
> > > Can't we replace this class with `std::mutex` directly?
> > Again, I should've included more context to the
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. I'll re-review the mutexor changes post-commit.
Comment at: CMakeLists.txt:121
option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of
pthread API"
rmaprath added a comment.
Ping.
https://reviews.llvm.org/D27575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Gentle ping.
https://reviews.llvm.org/D27575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Patch updated with more context.
https://reviews.llvm.org/D27575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 81062.
https://reviews.llvm.org/D27575
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
src/cxa_guard.cpp
src/cxa_thread_atexit.cpp
src/fallback_malloc.cpp
src/threading_support.h
test/CMakeLists.txt
rmaprath added inline comments.
Comment at: CMakeLists.txt:121
option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of
pthread API" OFF)
+option(LIBCXXABI_HAS_EXTERNAL_THREAD_API
+ "Build libc++abi with an externalized threading API.
EricWF
EricWF added a comment.
This LGTM. I'll approve after the inline comments are addressed.
Comment at: CMakeLists.txt:121
option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of
pthread API" OFF)
+option(LIBCXXABI_HAS_EXTERNAL_THREAD_API
+ "Build libc++abi
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
This is a replacement for https://reviews.llvm.org/D27204. Re-worked so that we
use the threading API of `libcxx` instead of creating a
11 matches
Mail list logo
