This revision was automatically updated to reflect the committed changes.
Closed by commit rL289885: [analyzer] Refine the diagnostics in the nullability
checker to differentiate… (authored by zaks).
Changed prior to commit:
https://reviews.llvm.org/D27600?vs=80925=81671#toc
Repository:
rL
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good.
While you are here, you might consider changing: the checkBind() diagnostic to
match the other diagnostics:
"Null assigned to a pointer which is expected to have non-null
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D27600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna updated this revision to Diff 80925.
zaks.anna added a comment.
Updated "null"-> "Null" as per Devin's suggestion.
https://reviews.llvm.org/D27600
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
test/Analysis/nullability-no-arc.mm
test/Analysis/nullability.mm
zaks.anna added a comment.
Looks like Sema uses "null" not only when referring to literals (see below).
Also, if we were referring to literals, we would use single quotes, no?
I suggest keeping as is for consistency with the wording that uses nil. I do
not see much difference between the two
dcoughlin added a comment.
I think in the 'null' case it might be better to keep it as "Null passed" or
even "Null value passed". This is different than the 'nil' case because the
diagnostic is not referring to a literal.
https://reviews.llvm.org/D27600
zaks.anna created this revision.
zaks.anna added a reviewer: dcoughlin.
zaks.anna added subscribers: dergachev.a, cfe-commits.
This is a big deal for ObjC, where nullability annotations are extensively
used. I've also changed "Null" -> "null" and removed "is" as this is the
pattern that Sema is
