This revision was automatically updated to reflect the committed changes.
Closed by commit rL300109: [Driver] Add compiler option to generate a
reproducer (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D27604?vs=80981=95035#toc
Repository:
rL LLVM
rsmith accepted this revision.
rsmith added a comment.
LGTM with one change.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:95
def err_drv_force_crash : Error<
- "failing because environment variable '%0' is set">;
+ "failing because %select{environment
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
My questions were answered. LGTM!
https://reviews.llvm.org/D27604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno added a comment.
Ping!
https://reviews.llvm.org/D27604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 80981.
bruno added a comment.
Update after Mehdi's review!
https://reviews.llvm.org/D27604
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
bruno added a comment.
> I am wondering if there is clearer name than `-gen-reproducer`.
Probably, I'm open to suggestions :-)
> IIUC, the goal is to extract all environment (system) dependent pieces,
> copying them to a folder where the compiler can be chroot-ed (via
> `-isysroot`).
It
mehdi_amini added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:95
def err_drv_force_crash : Error<
- "failing because environment variable '%0' is set">;
+ "failing because %select{environment variable|option}0 '%1' is set">;
def
v.g.vassilev added a comment.
Thanks for working on this, Bruno!
This would be a useful feature to us, too.
I am wondering if there is clearer name than `-gen-reproducer`.
IIUC, the goal is to extract all environment (system) dependent pieces, copying
them to a folder where the compiler can
bruno created this revision.
bruno added reviewers: rsmith, v.g.vassilev.
bruno added subscribers: cfe-commits, mehdi_amini.
One way to currently test the reproducers is to setup
"FORCE_CLANG_DIAGNOSTICS_CRASH=1" before invoking clang. This simulates
a crash and produces the same contents needed
