[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

curdeius closed this revision. curdeius added a comment. This has been superseded by D103245 . Closing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/ https://reviews.llvm.org/D27651 ___

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

Idadelveloper accepted this revision. Idadelveloper added a comment. Hello, Just wanted to follow up on these changes hoping they can be approved and merged. This will help me on a project I'm working on :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

jasperswallen added a comment. Is there any possibility of this being merged/reimplemented? This is a big annoyance for our project right now. If needed, I can potentially take a look at redoing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

ambroyz added a comment. In D27651#2111783 , @MyDeveloperDay wrote: > I don't see any LLVM contributions from the original author @KP for some > time, @ambroyz are you pinging this issue because your keen for someone to > look at it? I'm not sure if

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

MyDeveloperDay added a comment. I confirm this is still an issue as of v11 (trunk) and it looks like D21279: [clang-format] Fix some issues in clang-format's AlignConsecutive modes was landed even though its not closed. (the code behind D21279

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

ambroyz added a comment. topic, please, don't die CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/ https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP added inline comments. Comment at: unittests/Format/FormatTest.cpp:7878 +" int const i = 1;\n" +" int **j = 2, ***k;\n" +" int = i;\n" djasper wrote: > This looks wrong to me. Wouldn't you want to align

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

charlie added a comment. Would you please merge this patch into master & include it in daily build as soon as possible? My project really need this fix. Thanks a lot. https://reviews.llvm.org/D27651 ___ cfe-commits mailing list

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:255 +// If PointerAlignment is PAS_Right, keep *s or next to the token +if (Style.PointerAlignment == FormatStyle::PAS_Right && +Changes[i].Spaces != 0) { This needs to

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 95375. KP added a comment. Rebase on current trunk. Is there any chance to get this merge ? Please let me know if anything else is needed. Thanks, Ken-Patrick https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP added a comment. ping https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 86681. KP added a comment. Rebase after r293616. Replace isPointerOrReference with a direct check on the token type. https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP added a comment. In https://reviews.llvm.org/D27651#661490, @djasper wrote: > I have given stuff in WhitespaceManager access to the actual FormatToken in > r293616. Hopefully that simplifies this patch. Thanks! I'll try to rebase and see what can be improved.

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

djasper added a comment. I have given stuff in WhitespaceManager access to the actual FormatToken in r293616. Hopefully that simplifies this patch. https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 83829. KP added a comment. Rename IsPointerOrReference to isPointerOrReference to comply with coding style https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

djasper accepted this revision. djasper added a comment. Just some nits. Thanks for working on this! Comment at: lib/Format/WhitespaceManager.cpp:158 +static bool IsPointerOrReference(tok::TokenKind Kind) { + return Kind == tok::star || Kind == tok::amp || Kind ==

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

berenm accepted this revision. berenm added a comment. This revision is now accepted and ready to land. Awesome! Pinging @djasper https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 83676. KP added a comment. Thanks for the review! Split declarations in test cases with PAS_Middle/PAS_Left. Add tests with references and rvalue references. https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

berenm added a comment. Yes you are right, I believe it's happening for comma-separated declaration list. I think the algorithm tries to keep it clear that the pointer / reference marks are for each declared identifier and not part of the common type. I think that splitting the declarations

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

berenm added a comment. I'm trying to think of a scenario where *, && or & before tokens to be aligned would not indicate pointers or references, but as the alignment is only done for now on declarations and assignments, I can't find one. Maybe you could add one more test case to check Left

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP added a comment. ping https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP created this revision. KP added a reviewer: djasper. KP added a subscriber: cfe-commits. Herald added a subscriber: klimek. With AlignConsecutiveDeclarations and PointerAlignment: Right *s and were left dangling. For instance const char* const* v1; float const* v2; SomeVeryLongType