[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

clayborg added inline comments. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:92-93 +#elif defined(__APPLE__) && HAVE_CRASHREPORTER_INFO +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc ___crashreporter_info__,

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

thakis added inline comments. Herald added subscribers: llvm-commits, kristina. Herald added a project: LLVM. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:93 +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

On Mon, Dec 19, 2016 at 9:39 AM Sean Callanan wrote: > That would require making LLDB crash and collecting the relevant crash log > data out of the user's own logs. This isn't impossible – but additionally > the generation of that log is asynchronous and you don't quite

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

That would require making LLDB crash and collecting the relevant crash log data out of the user's own logs. This isn't impossible – but additionally the generation of that log is asynchronous and you don't quite know when it'll land. Would you be all right with a more restricted macOS-only unit

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

Test coverage? On Tue, Dec 13, 2016 at 2:39 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe retitled this revision from "Fix the linkage for > __crashtracer_info__" to "Prepare PrettyStackTrace for LLDB adoption". > spyffe updated the summary for

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

This revision was automatically updated to reflect the committed changes. Closed by commit rL289689: Prepare PrettyStackTrace for LLDB adoption (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D27683?vs=81304=81426#toc Repository: rL LLVM

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

beanz accepted this revision. beanz added a comment. LGTM other than a few style comments. Please clang-format before committing. Some of the formatting looks off (although that might just be my phone). Comment at: lib/Support/PrettyStackTrace.cpp:152 + va_start(ap, format);

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

spyffe added a comment. The LLDB side of this is https://reviews.llvm.org/D27735 Repository: rL LLVM https://reviews.llvm.org/D27683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

spyffe retitled this revision from "Fix the linkage for __crashtracer_info__" to "Prepare PrettyStackTrace for LLDB adoption". spyffe updated the summary for this revision. spyffe updated this revision to Diff 81304. Repository: rL LLVM https://reviews.llvm.org/D27683 Files: