cryptoad marked 4 inline comments as done.
cryptoad added a comment.
Thank you for the review Renato!
https://reviews.llvm.org/D28238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
Sounds good. Thanks!
https://reviews.llvm.org/D28238
___
cfe-commits mailing list
cryptoad added inline comments.
Comment at: test/Driver/linux-ld.c:623
+// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
+// RUN: --target=arm64-unknown-linux-gnu \
+// RUN: --gcc-toolchain="" \
rengolin wrote:
> cryptoad wrote:
> > rengolin
rengolin added inline comments.
Comment at: test/Driver/linux-ld.c:623
+// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
+// RUN: --target=arm64-unknown-linux-gnu \
+// RUN: --gcc-toolchain="" \
cryptoad wrote:
> rengolin wrote:
> > shouldn't
cryptoad added inline comments.
Comment at: test/Driver/linux-ld.c:623
+// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
+// RUN: --target=arm64-unknown-linux-gnu \
+// RUN: --gcc-toolchain="" \
rengolin wrote:
> shouldn't you have used your
rengolin added inline comments.
Comment at: test/Driver/linux-ld.c:623
+// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
+// RUN: --target=arm64-unknown-linux-gnu \
+// RUN: --gcc-toolchain="" \
shouldn't you have used your triple?
cryptoad updated this revision to Diff 83376.
cryptoad added a comment.
Adding tests to test/Driver.
https://reviews.llvm.org/D28238
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/opensuse_42.2_aarch64_tree/
test/Driver/Inputs/opensuse_42.2_aarch64_tree/usr/
rengolin added a comment.
Please, add tests to test/Driver.
https://reviews.llvm.org/D28238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cryptoad created this revision.
cryptoad added reviewers: chandlerc, bruno, bkramer.
cryptoad added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
openSuse has AArch64 support, with images running on the Raspberry Pi 3.
The libraries and headers live under the
