hintonda abandoned this revision.
hintonda added a comment.
Unable to test change here, so have included fix directly in
https://reviews.llvm.org/D20428.
https://reviews.llvm.org/D28258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith added a comment.
Looks OK. Is it possible to add a test case for this without
https://reviews.llvm.org/D20428? If not, this is small enough that rolling it
into https://reviews.llvm.org/D20428 (so it can be committed with its testcase)
would make sense.
https://reviews.llvm.org/D28258
hintonda updated this revision to Diff 83000.
hintonda added a comment.
Rollback previous change and instead only call
actOnDelayedExceptionSpecification if noexcept type is not EST_None.
https://reviews.llvm.org/D28258
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index:
hintonda added a comment.
Richard, what do you think about just avoiding the problem altogether by only
calling actOnDelayedExceptionSpecification is noexcept type != EST_None?
https://reviews.llvm.org/D28258
___
cfe-commits mailing list
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3547
NoexceptRange = SourceRange(KeywordLoc, T.getCloseLocation());
-} else {
- NoexceptType = EST_None;
}
} else {
rsmith wrote:
> Should `NoexceptRange` be set in
rsmith added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3547
NoexceptRange = SourceRange(KeywordLoc, T.getCloseLocation());
-} else {
- NoexceptType = EST_None;
}
} else {
Should `NoexceptRange` be set in the `else` case too,
hintonda created this revision.
hintonda added reviewers: sepavloff, rsmith, aaron.ballman.
hintonda added a subscriber: cfe-commits.
Treat invalid noexcept specifications in the same way we
treat invalid throw specifications, by not resetting the exception
type to EST_None, and testing isUsable
