EricWF updated this revision to Diff 83399.
EricWF added a comment.
- Merge with master
https://reviews.llvm.org/D28316
Files:
CMakeLists.txt
docs/DesignDocs/ThreadingSupportAPI.rst
docs/index.rst
include/__config
include/__config_site.in
include/__threading_support
rmaprath added a comment.
In https://reviews.llvm.org/D28316#636700, @EricWF wrote:
> In https://reviews.llvm.org/D28316#636686, @rmaprath wrote:
>
> > (btw, do those docs updates land on some web URL automagically when
> > committed?).
>
>
> Assuming the builder isn't broken then yes, the docs
EricWF updated this revision to Diff 83211.
EricWF marked an inline comment as done.
https://reviews.llvm.org/D28316
Files:
CMakeLists.txt
docs/DesignDocs/ThreadingSupportAPI.rst
docs/index.rst
include/__config
include/__config_site.in
include/__threading_support
lib/CMakeLists.txt
rmaprath added a comment.
This is much better (few nits inline). And many thanks for the docs update
(btw, do those docs updates land on some web URL automagically when committed?).
I think we should point out on the docs that
`_LIBCPP_HAS_THREAD_LIBRARY_EXTERNAL` is only meant for `libc++`
EricWF updated this revision to Diff 83201.
EricWF added a comment.
- Address inline comments
https://reviews.llvm.org/D28316
Files:
CMakeLists.txt
docs/DesignDocs/ThreadingSupportAPI.rst
docs/index.rst
include/__config
include/__config_site.in
include/__threading_support
smeenai added inline comments.
Comment at: docs/DesignDocs/ThreadingSupportAPI.rst:17
+
+The ``<__threading_support>`` header is where libc++ defines it's internal
+threading interface. It contains forward declarations of the internal threading
s/it's/its
EricWF added a comment.
@compnerd Just waiting on @rmaprath before committing. This is a breaking
change for his use case since this patch changes the semantics of
`_LIBCPP_HAS_THREAD_API_EXTERNAL` and `-DLIBCXX_HAS_EXTERNAL_THREAD_API`.
https://reviews.llvm.org/D28316
EricWF created this revision.
EricWF added reviewers: compnerd, rmaprath.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
This patch attempts to clean up the macro configuration mess in
`<__threading_support>`, specifically the mess involving external threading
