[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek closed this revision. Prazek added a comment. Pushed on branch. Please check if everything looks good when RC will be released. https://reviews.llvm.org/D28746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek added a comment. In https://reviews.llvm.org/D28746#646875, @mehdi_amini wrote: > Oh I didn't notice that we were in the clang Release Notes, actually I've > only updated the LLVM ones in the past. > > So yes, I think this should be in LLVM as well, I don't know if it should > differ in

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

mehdi_amini added a comment. Oh I didn't notice that we were in the clang Release Notes, actually I've only updated the LLVM ones in the past. So yes, I think this should be in LLVM as well, I don't know if it should differ in some way? https://reviews.llvm.org/D28746 _

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek added a comment. Shoud I add the same note to LLVM Release notes? https://reviews.llvm.org/D28746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek updated this revision to Diff 84504. Prazek marked an inline comment as done. Prazek added a comment. (PGO) https://reviews.llvm.org/D28746 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNo

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek marked 2 inline comments as done. Prazek added a comment. Cool, This still might require some small fixes - I haven't generate docs for it, so I will check it before release. https://reviews.llvm.org/D28746 ___ cfe-commits mailing list cfe-c

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: docs/ReleaseNotes.rst:70 + + - Integration with profile data. When available, profile data enables mo

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek updated this revision to Diff 84503. Prazek added a comment. update https://reviews.llvm.org/D28746 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@ -63

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

tejohnson added a comment. In https://reviews.llvm.org/D28746#646793, @Prazek wrote: > Maybe I should change ThinLTO for '-flto=thin' and also mention this > improvement in LLVM release notes? > > BTW '-flto=thin' is not documented in UsersManual It's documented here: http://clang.llvm.org/

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

mehdi_amini added inline comments. Comment at: docs/ReleaseNotes.rst:69 + called from cold callsite. + We need to mention ThinLTO in the Release Notes, so thanks for initiating this. We likely should go with a paragraph summarizing the improvements, I don't k

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek added a comment. Maybe I should change ThinLTO for '-flto=thin' and also mention this improvement in LLVM release notes? BTW '-flto=thin' is not documented in UsersManual https://reviews.llvm.org/D28746 ___ cfe-commits mailing list cfe-comm

[PATCH] D28746: Mention ThinLTO with PGO in ReleaseNotes 4.0

Prazek created this revision. Prazek added reviewers: tejohnson, mehdi_amini, hans. Prazek added a subscriber: cfe-commits. It would be good to also mention other improvements in ThinLTO for 4.0 release https://reviews.llvm.org/D28746 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rs