Re: [PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Antonio Maiorano via cfe-commits
On Fri, 20 Jan 2017 at 11:26 Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: ioeric added a comment. In https://reviews.llvm.org/D28943#651536, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > > > In https://reviews.llvm.org/D28943#651488, @amaiorano

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. In https://reviews.llvm.org/D28943#651536, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > > > In https://reviews.llvm.org/D28943#651488, @amaiorano wrote: > > > > > In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > > > > > > >

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added a comment. In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > In https://reviews.llvm.org/D28943#651488, @amaiorano wrote: > > > In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > > > > > @amaiorano: The test itself is correct. It's just that this test failed >

Re: [PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Antonio Maiorano via cfe-commits
You mean you build a modified version of clang-format where Style is initialized to getGoogleStyle()? I had wondered whether adding a -defaultStyle argument might be useful, specifically in the case where you want to pass in yaml that simply tweaks the default style, but I figured it's not much

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. In https://reviews.llvm.org/D28943#651488, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > > > @amaiorano: The test itself is correct. It's just that this test failed in > > our internal test. We could've fixed it internally, but the fix

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added a comment. In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > @amaiorano: The test itself is correct. It's just that this test failed in > our internal test. We could've fixed it internally, but the fix would be > ugly. Since the intended behavior is already covered in

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292604: [clang-format] Remove redundant test in style-on-command-line.cpp (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D28943?vs=85117=85122#toc Repository: rL LLVM

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. @amaiorano: The test itself is correct. It's just that this test failed in our internal test. We could've fixed it internally, but the fix would be ugly. Since the intended behavior is