[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

2017-01-24 Thread Dimitry Andric via Phabricator via cfe-commits
dim abandoned this revision. dim added a comment. Ok, back to Mozilla we go. https://reviews.llvm.org/D28981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

2017-01-23 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF resigned from this revision. EricWF added a comment. I think we've agreed that this change shouldn't proceed. Resigning as reviewer. https://reviews.llvm.org/D28981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

2017-01-23 Thread Jonathan Wakely via Phabricator via cfe-commits
jwakely added a comment. The __throw_xxx functions are not part of the public libstdc++ API and whatever Firefox is trying to do with them is not supported by libstdc++ and is undefined behaviour. Make it stop. https://reviews.llvm.org/D28981 ___

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

2017-01-23 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. In https://reviews.llvm.org/D28981#653908, @mclow.lists wrote: > > In https://reviews.llvm.org/rL279744, __throw_XXX() functions were > > introduced, partially for compatibility with software compiled against > > libstdc++. > > You're working from a false premise. These

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

2017-01-21 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. In https://reviews.llvm.org/rL279744, `__throw_XXX()` functions were introduced, partially for compatibility with software compiled against libstdc++. `_LIBCPP_NORETURN` is used on all of them, and when C++11 attributes are available, this gets defined as