mehdi_amini added inline comments.
Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464
if (C.getDriver().isSaveTempsEnabled() &&
- !C.getDriver().embedBitcodeInObject() && isa(JA))
+ !C.getDriver().embedBitcodeInObject() && !C.getDriver().isUsingLTO() &&
+ isa(JA))
steven_wu added a comment.
Sorry I just notice that when I look at driver today.
Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464
if (C.getDriver().isSaveTempsEnabled() &&
- !C.getDriver().embedBitcodeInObject() && isa(JA))
+ !C.getDriver().embedBitcodeInObject()
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292960: Split isUsingLTO() outside of embedBitcodeInObject()
and embedBitcodeMarkerOnly… (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D29065?vs=85511=85605#toc
steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.
Depending on how you look at the previous commit, you can think that as a new
API or just rename the old API. I actually dont think there is too much issue
names. Plz go ahead.
mehdi_amini added a comment.
In https://reviews.llvm.org/D29065#654336, @steven_wu wrote:
> I think you should add a new API for embedBitcodeMarkerEnabled() or revert
> the name the APIs to before https://reviews.llvm.org/rL287084.
I'm missing where https://reviews.llvm.org/rL287084 changed
steven_wu added a comment.
I think you should add a new API for embedBitcodeMarkerEnabled() or revert the
name the APIs to before https://reviews.llvm.org/rL287084.
https://reviews.llvm.org/D29065
___
cfe-commits mailing list
mehdi_amini created this revision.
These accessors maps directly to the command line option.
https://reviews.llvm.org/D29065
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/lib/Driver/Tools.cpp
Index: clang/lib/Driver/Tools.cpp
