dblaikie added a comment.
Oops, forgot to write stuff so the approval appears on-list.
Anyway - looks good/approved.
https://reviews.llvm.org/D29205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danielcdh updated this revision to Diff 86292.
danielcdh added a comment.
update
https://reviews.llvm.org/D29205
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDebugInfo.cpp
Index: lib/CodeGen/CGDebugInfo.cpp
===
---
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
mehdi_amini wrote:
> danielcdh wrote:
> > mehdi_amini
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
danielcdh wrote:
> mehdi_amini wrote:
> > Why should
danielcdh added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
mehdi_amini wrote:
> Why should we warn on mismatch?
In
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:452
+ if (CodeGenOpts.DebugInfoForProfiling)
+getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling",
1);
Why should we warn on mismatch?
danielcdh updated this revision to Diff 86058.
danielcdh added a comment.
change to use module flag.
https://reviews.llvm.org/D29205
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenModule.cpp
Index: lib/CodeGen/CodeGenModule.cpp
danielcdh created this revision.
Herald added a subscriber: mehdi_amini.
cfe change for https://reviews.llvm.org/D29203
https://reviews.llvm.org/D29205
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenFunction.cpp
Index: lib/CodeGen/CodeGenFunction.cpp
