This revision was automatically updated to reflect the committed changes.
Closed by commit rL293732: clang-cl: Evaluate arguments left-to-right in
constructor call with initializer… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D29350?vs=86496=86549#toc
Repository:
hans added a comment.
In https://reviews.llvm.org/D29350#662525, @rnk wrote:
> Can you check if we got this wrong in clang 3.8 and 3.9? I'm wondering if
> this was a regression, or if we always got this wrong.
I tried back to 3.5, and it seems we just always got it wrong.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Can you check if we got this wrong in clang 3.8 and 3.9? I'm wondering if this
was a regression, or if we always got this wrong.
https://reviews.llvm.org/D29350
hans created this revision.
clang-cl would evaluate the arguments right-to-left (see PR), and for
non-Windows targets I suppose we only got it because we were already emitting
left-to-right in CodeGenFunction::EmitCallArgs.
https://reviews.llvm.org/D29350
Files:
lib/CodeGen/CGClass.cpp
