tigerleapgorge closed this revision.
tigerleapgorge added a comment.
warn-thread-safety-parsing.cpp has been commited in
https://reviews.llvm.org/rL296193.
The following FIXME has been added to track this bug.
//FIXME: Bug 32066 - Error should be emitted irrespective of C++ dialect
tigerleapgorge accepted this revision.
tigerleapgorge added a comment.
This revision is now accepted and ready to land.
Of the 3 tests.
format-strings.cpp and printf-cstr.cpp have been commited in r294979
For warn-thread-safety-parsing.cpp, bug 32066 has been filed to track the lack
of thread
aaron.ballman added a comment.
In https://reviews.llvm.org/D29685#675306, @tigerleapgorge wrote:
> @aaron.ballman Thank you for the code review. I take it I can commit the
> first 2 tests?
Yes, the first two tests are good to commit.
https://reviews.llvm.org/D29685
tigerleapgorge added a comment.
@aaron.ballman Thank you for the code review. I take it I can commit the first
2 tests?
@delesley Thank you for the analysis. Should I open a bugzilla to track this
issue?
https://reviews.llvm.org/D29685
___
delesley added a comment.
I agree with Aaron here. Those thread safety errors are supposed to fire;
simply disabling the unit tests because they no longer fire is not acceptable.
I also don't understand how this could be a bug with the thread safety
analysis, since these particular errors
aaron.ballman added a reviewer: delesley.
aaron.ballman added a subscriber: delesley.
aaron.ballman added a comment.
The changes to the format string look good to me, but the changes to the
thread-safety attributes do not make sense. I *think* those are indicative of a
bug with thready safety
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch contains 3 tests, previously in review
https://reviews.llvm.org/D21626.
First two tests involve printf format attributes.
The third test involve thread safety attribute.
Here are the descriptions
